-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Native Flow Response reply type definition #282
Conversation
Thanks for the PR! I didn't know this webhook notification existed. There are two nit details which will trigger a CI error, and one from the official documentation: Here it says the "interactive" object will also contain an "action" property, and the "nfm_reply" might contain a "name" and "body" strings. If you don't mind, could you fix and add those extra types? If not, don't worry, I can keep working from this. Thanks! |
Prefer using Also, run |
Got ya, will fix the issues and run linting locally before proposing the final changes. Thanks! |
I added 2 more commits to the PR, super minor nit picks and replaced "address_response" with "address_message" based on the documentation. Let me know if there's something else you would like to add, and if not I can merge it and release it tomorrow. Thanks for contributing! |
Awesome, this all looks good now. I do have some other changes, but they are not related to this one. They have to deal with Anyhow... thanks for the great work! |
This PR adds the type definition for an interactive nfp_reply message. This message is received when sharing an address, or completing an flow.